From: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Date: Thu, 28 Feb 2008 03:31:01 GMT
Subject: Re: [PATCH 6/9] Completely move out worktree setup from setup_git_directory_gently()
Message-ID: <fcaeb9bf0802271931t559d4bd1n86bb5c644b082274@mail.gmail.com>
In-Reply-To: <7vy795lt89.fsf@gitster.siamese.dyndns.org>

On Thu, Feb 28, 2008 at 9:17 AM, Junio C Hamano <gitster@pobox.com> wrote:
> Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
>
>  > -     prefix = setup_git_directory_gently(&nongit);
>  > -     init_revisions(&rev, prefix);
>  > +     setup_git_directory_gently(&nongit);
>  > +     init_revisions(&rev, NULL);
>
>
>
> > @@ -233,19 +233,20 @@ int cmd_diff(int argc, const char **argv, const char *prefix)
>  > ...
>
> > -     init_revisions(&rev, prefix);
>  > +     init_revisions(&rev, NULL);
>
>  Hmm.  How is the effect of this change compensated later to give
>  proper prefix value to rev.diffopt.prefix?
>

I assume you meant rev.prefix? rev.prefix is set right before
setup_revisions(). (grr.. I think I left an redundant
rev.diffopt.skip_stat_unmatch assignment)
-- 
Duy