From: Nguyen Thai Ngoc Duy Date: Wed, 28 Nov 2007 14:27:21 GMT Subject: Re: [PATCH] Replace instances of export VAR=VAL with VAR=VAL; export VAR Message-ID: In-Reply-To: <85lk8ia1nw.fsf@lola.goethe.zz> On Nov 28, 2007 9:24 PM, David Kastrup wrote: > "Nguyen Thai Ngoc Duy" writes: > > > On Nov 28, 2007 8:57 PM, Johannes Schindelin wrote: > >> > >> It might be POSIX, but there are shells that do not like the > >> expression 'export VAR=VAL'. To be on the safe side, rewrite them > >> into 'VAR=VAL' and 'export VAR'. > > > > Why leave test scripts behind? > > Good keyword: how about starting the basic tests by testing for shell > features that are known and accepted to be used in git? > > That way, we get direct feedback when feature assumptions are > problematic with some shells. Uh.. I meant there are "export VAL=VAL" usage in test scripts and they should be fixed as well. Anyway your idea is nice. -- Duy