From: Nguyen Thai Ngoc Duy Date: Wed, 07 Mar 2007 12:17:42 GMT Subject: Re: git's is_inside_git_dir too strict? Message-ID: In-Reply-To: On 3/7/07, Johannes Schindelin wrote: > > Complaints include "cannot be used without a working tree" and "This > > operation must be run in a work tree". Can I have the former behaviour > > back in some ways? > > Well, there is a real problem with "This operation must be run in a work > tree". What operation is that? We tried to make it hard to overwrite > things in $GIT_DIR by running Git operations meant for the working tree, > and it seems like you are running one of them. >From this command: git --git-dir=/home/pclouds/blog/data.git ls-files --others --modified 2007-03-07T18_52_41.txt It was run in /home/pclouds/blog/data, which is the working directory of data.git. By the way, is it plausible to add --git-workdir option to specify working directory? With that option, I won't need to chdir to the working directory, run git commands and chdir back. > > However, I think that is_bare_repository() really should check if > $GIT_DIR is a prefix of $(pwd). Because if it is not, we are likely to run > in a detached work tree. > > If you agree, then is_inside_git_dir() might actually be a better way to > ask if the repo is bare than is_bare_repository(). > > Comments? I didn't follow git development lately so I'm afraid I'm incapable to comment on this :-) > > Ciao, > Dscho > > -- Duy