From: Johannes Sixt Date: Tue, 01 Apr 2025 16:40:51 GMT Subject: Re: [PATCH v2 0/3] gitk: override PATH search only on Windows Message-ID: In-Reply-To: <20250401030102.297272-1-mlevedahl@gmail.com> Am 01.04.25 um 05:00 schrieb Mark Levedahl: > Restrict overrides of exec/open to Windows only, as > the need for this is Tcl adding the current working directory > to $PATH on Windows. Recent modifications to this render > gitk unusable on Cygwin, isolating these overrides to Windows only > both fixes that breakage andk reduces the liklihood of similar > issues in the future. > > patch summary: > 1 - modifies the existing code to restrict the overrides > to Windows, restoring other platorms to native exec/open. > 2 - remove now superflous variable _search_exe. > 3 - fix the override code to avoid path search given a > relative path like foo/bar. > > --- > Changes since v1 - fixed commit ID reference for git-gui, otherwise > improved commit message in patch 1. > Added patches 2 and 3. > > Mark Levedahl (3): > gitk: override $PATH search only on Windows > gitk: _search_exe is no longer needed > gitk: limit PATH search to bare executable names Thank you for following up. These all look good. Patch 3 is a good find! I've inserted a patch 0.5/3 that replaces the existing TAB characters with four SP in the indentation. Thanks, -- Hannes