From: Kaartic Sivaraam Date: Tue, 03 Nov 2026 07:54:52 GMT Subject: Re: [PATCH v4 0/4] Standardize early option scanning Message-ID: In-Reply-To: <20261102151447.734680-6-christian.couder@gmail.com> On 11/2/26 20:44, Christian Couder wrote: > Changes since v3 > ================ > > Thanks a lot to Junio, Kaartic and Cynthia who reviewed previous > versions. > > There are a number of small changes since v3: > > - In patch 2/4, a `switch` statement is now used in parse_long_opt() > to process the result from lookup_long_opt(). > > - In patch 3/4, a parse_options_check() call has been added to > early_scan_options(), after aliases are preprocessed, so that the > options are checked before the scan relies on them, rather than > only later by parse_options(). > > - In patch 3/4, in "parse-options.h": > > - the comment before early_scan_fn() has been improved to mention > that the `option` argument may point into a temporary copy of the > options, and > > - the end of the comment before early_scan_options() has been made > clearer and now mentions that EARLY_SCAN_STOP_AT_NON_OPTION is > safe to use even if PARSE_OPT_STOP_AT_NON_OPTION is not passed to > parse_options(). > > - In patch 4/4: > > - the comment before the call to early_scan_options() in > cmd_fast_import() has been improved to explain why > EARLY_SCAN_STOP_AT_NON_OPTION is passed, > > - a new test has been added to check that unsafe "feature" commands > from the stream are refused when `--allow-unsafe-features` comes > after a non-option argument, which parse_argv() rejects anyway. > Thanks! This version looks good to me! -- Sivaraam