From: Derrick Stolee Date: Tue, 04 Sep 2018 17:12:55 GMT Subject: Re: [PATCH v2 0/1] Define GIT_TEST_COMMIT_GRAPH for commit-graph test coverage Message-ID: In-Reply-To: On 9/4/2018 12:49 PM, Duy Nguyen wrote: > On Wed, Aug 29, 2018 at 2:49 PM Derrick Stolee via GitGitGadget > wrote: >> The commit-graph (and multi-pack-index) features are optional data >> structures that can make Git operations faster. Since they are optional, we >> do not enable them in most Git tests. The commit-graph is tested in >> t5318-commit-graph.sh (and t6600-test-reach.sh in ds/reachable), but that >> one script cannot cover the data shapes present in the rest of the test >> suite. >> >> This patch introduces a new test environment variable, GIT_TEST_COMMIT_GRAPH >> . Similar to GIT_TEST_SPLIT_INDEX, it enables the commit-graph and writes it >> with every git commit command. Thanks, Duy, for pointing out this direction >> [1]. > Any reason to not add this new flag in ci/run-build-and-tests.sh > (which is used by Travis)? I see your note about VSTS but I don't see > why it has to be exclusive to VSTS. I only wanted to volunteer resources that I know are available. I am looking into an additional test run in Travis CI builds, but didn't want to presume the extra resources would be available.