From: Sverre Rabbelier <srabbelier@gmail.com>
Date: Sun, 01 Nov 2009 20:54:24 GMT
Subject: Re: Fw: git-core: SIGSEGV during {peek,ls}-remote on HTTP remotes.
Message-ID: <fabb9a1e0911011254j316920e6y63c4f129f7df186d@mail.gmail.com>
In-Reply-To: <alpine.LNX.2.00.0911011504460.14365@iabervon.org>

Heya,

On Sun, Nov 1, 2009 at 21:16, Daniel Barkalow <barkalow@iabervon.org> wrote:
> If we change the ls-remote.c case, it becomes impossible for a struct
> transport to ever have a NULL remote field. And the change to ls-remote
> removes a special case. I'd go so far as to say that ls-remote.c should
> provide a struct remote, and transport_get should enforce that there's a
> struct remote.

If that is the case (that we can eliminate the only special case), I
agree that we should fix it there, where it will be the least effort.
I got the impression from Junio's original post that there are
multiple places that would have to be fixed, and I figured that we
should fix it where it will be the least amount of effort :).

-- 
Cheers,

Sverre Rabbelier