From: Sverre Rabbelier Date: Fri, 23 Oct 2009 19:16:59 GMT Subject: Re: ks/precompute-completion Message-ID: In-Reply-To: <7vd44eaqc5.fsf@alter.siamese.dyndns.org> Heya, On Fri, Oct 23, 2009 at 13:59, Junio C Hamano wrote: >  1. The series will break your rc script (either $HOME/.bashrc, or >    system-side) that sources $git/contrib/completion/git-completion.bash >    because it has to be built; having "make" generate it may alleviate >    the issue, but "make clean" will break it again, so it is not >    something you can solve in any way other than changing your setting. This is my main concern, adding 'bash_completion' as a target to all: would be ok; why would 'make clean' break it? As long as you don't add "make -C contrib/completion clean' to the main clean target there's no problem? -- Cheers, Sverre Rabbelier