From: Sverre Rabbelier Date: Thu, 13 Aug 2009 22:17:59 GMT Subject: Re: [PATCH 2/4] fast-import: define a new option command Message-ID: In-Reply-To: <20090813221213.GR1033@spearce.org> Heya, On Thu, Aug 13, 2009 at 15:12, Shawn O. Pearce wrote: > No, I don't have a really good reason for the command line overrides > the file other than this simple rule: Nice anecdote :P. > What is this, gang up on Shawn's words-of-wisdom week?  Both this > thread and my intern this week have been argueing with me about > what seem to me to be fairly trivial things.  Maybe I just need to > take vacation.  Good thing I have one coming in 5 weeks. Didn't you get the memo, you could be crashing an airplane [0] like that ;). > I say use the version where we store the values (e.g. file names) > during option parsing, and then actually apply those saved values > just before the first non-option command.  Which I think only has > an impact on the import-marks option, the rest are all just simple > variable updates whose values aren't read until after the first > non-option command anyway. Ok, that's v3, speaking of which, does it look good enough for inclusion? [0] http://www.thehackerchickblog.com/2009/05/plane-crashes-software-failures-and.html -- Cheers, Sverre Rabbelier