From: Sverre Rabbelier Date: Thu, 13 Aug 2009 17:44:51 GMT Subject: Re: [PATCH 2/4] fast-import: define a new option command Message-ID: In-Reply-To: <20090813174119.GP1033@spearce.org> Heya, On Thu, Aug 13, 2009 at 10:41, Shawn O. Pearce wrote: > Uh, no, if we have "option import-marks=..." and we can't find the > file "..." and we have no --import-marks command line flag that > would have overridden it, we need to abort with an error. Ah, then how about in option_import_marks() we only store the name of the file, like in option_export_marks, and at the end, when we reach the first non-option command (and we've parsed argv), we read the file. That way it's only read once, and it deals with the above scenario. -- Cheers, Sverre Rabbelier