From: Sverre Rabbelier Date: Fri, 27 Feb 2009 12:29:32 GMT Subject: Re: [RFH] rebase -i optimization Message-ID: In-Reply-To: Heya, On Fri, Feb 27, 2009 at 11:50, Johannes Schindelin wrote: > On one hand, I could imagine that it is just a question of skipping those > 'pick' commands that do not contribute anything.  That would be a pretty > simple function that would be called at the very beginning. Exactly, that's what I had in mind. > On the other hand, this very simple strategy would fail pretty quickly > (and badly) with -i -p.  And that is the stuff I am mostly spending my Git > time budget on these days. I would be fine with making this optimization optional (with a config option?), and barf if both the optimization and -p are supplied. We could even automagically ignore the config option for -p, and only barf if both -p and this option are specified explicitly? > Having said that, I think yours might be such a common case that it is > worth optimizing for. Does this fit in your git time budget, or would you prefer I have a stab at it? If the latter, any hints on where to put such a call? -- Cheers, Sverre Rabbelier