From: Phillip Wood <phillip.wood123@gmail.com>
Date: Wed, 08 Jan 2020 18:55:53 GMT
Subject: Re: [PATCH v3 10/15] rebase: add an --am option
Message-ID: <fabb4048-41fa-0b24-1716-e63237478956@gmail.com>
In-Reply-To: <xmqqmuax3lzv.fsf@gitster-ct.c.googlers.com>

On 08/01/2020 17:18, Junio C Hamano wrote:
> Phillip Wood <phillip.wood123@gmail.com> writes:
> 
>> I view this change in the default backend as similar to the rewrite in
>> C in that it is an implementation detail we're changing that should be
>> transparent (and beneficial in terms of performance) to the
>> user. There we provided a configuration variable but not a command
>> line option to control if it was used or not.
> 
> Do you mean things like GIT_TEST_ADD_I_USE_BUILTIN?  I think it is
> OK to have such an escape mechanism to allow people to opt out of
> a new reimplementation until it matures, but I do not offhand recall
> doing so with config.

I was thinking of rebase.usebuiltin

Best Wishes

Phillip