From: lilinchao@oschina.cn <lilinchao@oschina.cn>
Date: Tue, 11 May 2021 02:17:03 GMT
Subject: Re: Re: [PATCH] builtin/gc: warn when core.commitGraph is disabled
Message-ID: <fa99dc5ab1fe11eb92230026b95c99cc@oschina.cn>
In-Reply-To: <ceb22d54b18611ebb304a4badb2c2b1147508@gmail.com>

>
>On Mon, May 10 2021, lilinchao@oschina.cn wrote:
>
>> From: Li Linchao <lilinchao@oschina.cn>
>>
>> Throw warning message when core.commitGraph is disabled in commit-graph
>> maintenance task.
>
>Won't this cause the gc.log issue noted in
>https://lore.kernel.org/git/87r1l27rae.fsf@evledraar.gmail.com/
>
>More importantly, I don't think this UX makes sense. We said we didn't
>want it, so why warn about it?
>
>Maybe there are good reasons to, but this commit message / patch doesn't
>make the case for it...
> 
Forgive me, I don't know any of your previous discussions.
Sorry for disturbing.

>
>> Signed-off-by: Li Linchao <lilinchao@oschina.cn>
>> ---
>>  builtin/gc.c | 4 +++-
>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/builtin/gc.c b/builtin/gc.c
>> index 98a803196b..90684ca3b3 100644
>> --- a/builtin/gc.c
>> +++ b/builtin/gc.c
>> @@ -861,8 +861,10 @@ static int run_write_commit_graph(struct maintenance_run_opts *opts)
>>  static int maintenance_task_commit_graph(struct maintenance_run_opts *opts)
>>  {
>>  prepare_repo_settings(the_repository);
>> -	if (!the_repository->settings.core_commit_graph)
>> +	if (!the_repository->settings.core_commit_graph) {
>> +	warning(_("skipping commit-graph task because core.commitGraph is disabled"));
>>  return 0;
>> +	}
>> 
>>  close_object_store(the_repository->objects);
>>  if (run_write_commit_graph(opts)) {
>