From: Johannes Sixt <j6t@kdbg.org>
Date: Thu, 20 Apr 2017 16:30:28 GMT
Subject: Re: [PATCH v3 05/12] refs: move submodule slash stripping code to get_submodule_ref_store
Message-ID: <fa37a980-d984-1834-6d2e-cce60486ec33@kdbg.org>
In-Reply-To: <CACsJy8A1aR-=QqqZdw+i5Hv2kXptTzYcn5tFsMBDYk6vBwUwZg@mail.gmail.com>

Am 20.04.2017 um 13:56 schrieb Duy Nguyen:
> On Thu, Apr 20, 2017 at 5:02 AM, Johannes Sixt <j6t@kdbg.org> wrote:
>> What is the source of the value of 'submodule'? Is it an index entry? Or did
>> it pass through parse_pathspec? In these cases it is correct to compare
>> against literal '/'. Otherwise, is_dir_sep() is preferred.
>
> I've looked at the callers. Yes it is a path and is_dir_sep() should
> be used. Since this has been like this in the current code, unless
> there's some more changes in this series or you insist, I would hold
> this change back,

I won't insist because we have it the old way since a decade without 
issue reports.

-- Hannes