From: Jakub Narebski <jnareb@gmail.com>
Date: Mon, 06 Aug 2007 00:21:35 GMT
Subject: Re: [PATCH] send-email: let sanitize_address_rfc822 do rfc2047 quoting
Message-ID: <f95pie$8lv$1@sea.gmane.org>
In-Reply-To: <11863445481996-git-send-email-ukleinek@informatik.uni-freiburg.de>

[Uwe Kleine-König <ukleinek@informatik.uni-freiburg.de>,
 git@vger.kernel.org]

Uwe Kleine-König wrote:

> Without this patch I'm not able to properly send emails as I have a
> non-ascii character in my name.

Nice.

> The former version tried to fix-up the real name part with double quotes
> if it includes a '.'.  I removed this as rfc2047 can handle a dot, too.

Not nice. I'd rather use double quotes if rfc2047 is not needed.
It means:
 - no quotes for us-ascii name, without '.'
 - quotes for us-ascii name with '.' and perhaps other forbidden characters
   like '"' or something
 - full rfc2047 quoting if name contains characters outside us-ascii.

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git