From: Jon Simons <jon@jonsimons.org>
Date: Sun, 11 Oct 2026 02:35:33 GMT
Subject: Re: [PATCH 00/15] push: speed up client-side refspec matching
Message-ID: <f949a5fa-5485-4ae4-a7dc-75afaef798cc@jonsimons.org>
In-Reply-To: <4fcdf05d-b558-4471-b696-bd7c285f49e2@app.fastmail.com>

On 10/9/26 4:18 PM, Kristoffer Haugsbakk wrote:
> On Fri, Oct 9, 2026, at 21:29, Jon Simons wrote:
>> Guide to changes:
>>
>>  - Commits are ordered to introduce failing tests for behavioral
>>    changes and bugfixes, before the code change that fixes them
> 
> This project prefers introducing the 
> regression test and fix in the same commit.
> 

Thanks, I did not know this, and in searching I now find that this is a
common review feedback [1].  And the commit history also shows that it
is uncommon for a series to be merged that introduces a failing test
then fix in a subsequent commit.

I'll look at squashing the commits that introduce new test_expect_failure
cases up into the commits that toggles them passing, for v2, after first
letting the v1 soak for comments.


-Jon

[1] A couple examples of feedback and rationale to not to do this from
    August 2025 here:

    - https://lore.kernel.org/git/xmqqqzxpzo8b.fsf@gitster.g/
    - https://lore.kernel.org/git/xmqqfrdk3aqy.fsf@gitster.g/