From: Jakub Narebski Date: Sat, 28 Jul 2007 14:32:36 GMT Subject: Re: git-svn rebase screwing up commit messages Message-ID: In-Reply-To: <7vk5skps1g.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Sean writes: > >>> Having said all that, so that the readers understand the >>> background, here is a not-so-heavily-tested patch, which might >>> help. It passes all the test suite as before, but that tells >>> how existing git-svn tests do not test many things. >>> >>> I am not considering this for inclusion right now, by the way. >> >> FWIW your patch fixed my test case here. > > Actually the patched behaviour actively encourages a bad (not in > the sense that those oneline tools will not work well, but in > the sense that these messages are reader unfriendly) practice; I > do not think what the patch did deserves to be called "fixed". > > And that is one of the reasons, other than that we are in -rc > freeze that we do not add anything but unarguable fixes, that I > am not considering the patch for inclusion right now. I think that git should not enforce this policy. Think import and exchange with foreign SCMs which do not follow this, argueably very reasonable, one-line summary policy. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git