From: Kristoffer Haugsbakk Date: Fri, 28 Jun 2024 15:30:08 GMT Subject: Re: [PATCH 1/4] refs: add referent parameter to refs_resolve_ref_unsafe Message-ID: In-Reply-To: On Fri, Jun 7, 2024, at 00:44, Junio C Hamano wrote: > I found the previous occurrences of the same problem: > > https://lore.kernel.org/git/xmqqjzm3qumx.fsf@gitster.g/ > https://lore.kernel.org/git/xmqqh6hkxox6.fsf@gitster.g/ > > The last message in the thread > > > https://lore.kernel.org/git/CAMbn=B7J4ODf9ybJQpL1bZZ7qdWSDGaLEyTmVv+ZBiSeC9T+yw@mail.gmail.com/ > > says that the original user of GGG found what was wrong in the way > the user was using GGG to send and fixed it, but unfortunately we > didn't hear exactly *what* the breakage was and *how* it was fixed. > > Aryan, do you remember what the problem was and more importantly > what the fix was? > > Thanks. Yes, Aryan didn’t explain what the issue was. But Linus Arver (+CC) in that first thread/link figured out what was happening in his case:[1] > I realize now that it's because I copy/pasted the "Cc: ..." lines in the PR > description from > https://github.com/gitgitgadget/git/pull/1632#issue-2068188239, such > that when I pasted those in for the PR description for this series at > https://github.com/gitgitgadget/git/pull/1694#issue-2187804953, it > carried over the email addresses as Markdown-formatted hyperlinks. > Currently it reads > > Cc: Christian Couder [chriscool@tuxfamily.org](mailto:chriscool@tuxfamily.org) > Cc: Junio C Hamano [gitster@pobox.com](mailto:gitster@pobox.com) > Cc: Emily Shaffer [nasamuffin@google.com](mailto:nasamuffin@google.com) > cc: Josh Steadmon [steadmon@google.com](mailto:steadmon@google.com) > cc: Randall S. Becker [rsbecker@nexbridge.com](mailto:rsbecker@nexbridge.com) > cc: Christian Couder [christian.couder@gmail.com](mailto:christian.couder@gmail.com) > cc: "Kristoffer Haugsbakk" [code@khaugsbakk.name](mailto:code@khaugsbakk.name) > cc: "Kristoffer Haugsbakk" > > when I click on "edit", where the last line must be from your manual > fix which GGG picked up. I've cleaned up the PR description manually > now, and for this message I'm also attempting to clean up those square > brackets. When I read that I assumed that Aryan had made the same mistake. 🔗 1: https://lore.kernel.org/git/owly4jd741ph.fsf@fine.c.googlers.com/ -- Kristoffer Haugsbakk