From: Renato Botelho Date: Thu, 03 Jul 2025 12:40:54 GMT Subject: Re: [PATCH] config.mak.uname: update settings for FreeBSD Message-ID: In-Reply-To: On 12/06/25 00:47, Junio C Hamano wrote: > Brad Smith writes: > >> FreeBSD 6.0 has memmem(). > > And anything older than that no longer matters? The oldest supported version of FreeBSD is 13.5, which will EOL in April 2026. > That may indeed be true (6.0 was from Nov 2005), but if that is the > reason why we simply lose NO_MEMMEM (instead of conditionally losing > for 6.0 and newer), that needs to be explained in the proposed log > message, together with the reason why we no longer do anything > special with version "4.x" (which could be "We ditch the support for > anything older than 6.0"). > > Assuming that our stance is "anything older than 6.0 no longer > matters", the patch itself looks good. > >> Signed-off-by: Brad Smith >> --- >> config.mak.uname | 6 ------ >> 1 file changed, 6 deletions(-) >> >> diff --git a/config.mak.uname b/config.mak.uname >> index b1c5c4d5e8..da592eeaa0 100644 >> --- a/config.mak.uname >> +++ b/config.mak.uname >> @@ -302,16 +302,10 @@ ifeq ($(uname_S),FreeBSD) >> ifeq ($(firstword $(subst -, ,$(uname_R))),10.1) >> OLD_ICONV = YesPlease >> endif >> - NO_MEMMEM = YesPlease >> BASIC_CFLAGS += -I/usr/local/include >> BASIC_LDFLAGS += -L/usr/local/lib >> DIR_HAS_BSD_GROUP_SEMANTICS = YesPlease >> USE_ST_TIMESPEC = YesPlease >> - ifeq ($(shell expr "$(uname_R)" : '4\.'),2) >> - PTHREAD_LIBS = -pthread >> - NO_UINTMAX_T = YesPlease >> - NO_STRTOUMAX = YesPlease >> - endif >> PYTHON_PATH = /usr/local/bin/python >> PERL_PATH = /usr/local/bin/perl >> HAVE_PATHS_H = YesPlease > > -- Renato Botelho