From: Nuno Sá <noname.nuno@gmail.com>
Date: Thu, 10 Mar 2022 08:37:18 GMT
Subject: Re: git notes question
Message-ID: <f5be5b264f30f689546db3883b4b64c88ba00cb3.camel@gmail.com>
In-Reply-To: <xmqqee3bm2b8.fsf@gitster.g>

On Wed, 2022-03-09 at 10:02 -0800, Junio C Hamano wrote:
> Nuno Sá <noname.nuno@gmail.com> writes:
> 
> > AFAICT, git-format-patch looks to be using --pretty=email and I
> > think
> > we can use --pretty in git-format-patch but having to mimic the
> > email
> > format "by hand" is just painful and I was hoping a better way
> > could
> > exist.
> 
> Well, this time it was "Notes:" label, but the next person who
> wants to see a deviation from the canned "email" format would want a
> deviation different from yours.  Perhaps they want a different way

I'm surely missing something but I'm not sure this is specific to the
email format? It's just that git-notes by default will always either
append the "Notes:" or "Notes (<refname>):" independent of the
predefined format you use. The only way to stop it from doing that is,
apparently, by using your own --format=<template>...

What I was asking was just if there was a way to not use these default
strings. I don't think this would open all kind of deviations... Either
you use these default strings or don't. But I think these strings are
probably used/important for git log? So we can know what is commit
message and what are notes...

> to format the author name?  Perhaps they want a different way to
> separate the title (to be on the "Subject:" line) out of the commit
> message?  Perhaps they want to see the log message be indented?
> Perhaps they want to see the message from the notes be line-wrapped?
> Perhaps they want to see the message from the notes not to be
> indented?  Perhaps they want to see the "Notes (amlog):" label to
> format the name of the notes tree differently?
> 
> Where would that end?  We have to draw the line somewhere.
> 
> The customizability via --format=<template> is given for these
> people who want to futz with that line.  One thing that may be a
> good little project to help them is to make sure that the vanilla
> "--pretty=email" can be reimplemented as "--format=<template>" (I
> doubt it is), design a way to fill the gaps (if there are) to get
> there.  Once that is done, write down the "--format=<template>" that
> is equivalent to "--pretty=email" somewhere in the doc, to give
> those who want to derive from the canned format some reasonable
> starting point.

Well, this would be surely nice. For now, I will just remove it by hand
or script something to do it before calling git-send-email.

Thanks for the feedback!
- Nuno Sá