From: Dragan Simic Date: Thu, 11 Jan 2024 05:39:13 GMT Subject: Re: [DISCUSS] Introducing Rust into the Git project Message-ID: In-Reply-To: On 2024-01-11 01:33, Elijah Newren wrote: > On Wed, Jan 10, 2024 at 1:57 PM Dragan Simic > wrote: >> >> Thus, Git should probably follow the same approach of not converting >> the >> already existing code > > I disagree with this. I saw significant performance improvements > through converting some existing Git code to Rust. Granted, it was > only a small amount of code, but the performance benefits I saw > suggested we'd see more by also doing similar conversions elsewhere. > (Note that I kept the old C code and then conditionally compiled > either Rust or C versions of what I was converting.) Well, it's also possible that improving the old C code could also result in some performance improvements. Thus, quite frankly, I don't see that as a valid argument to rewrite some existing C code in Rust. > Further, I found a really old bug from this effort as well[1], and I > find it extremely unlikely that I would have found that bug otherwise. > So, converting to Rust can even improve our existing C code. > >> , but frankly, I don't see what would actually be >> the "new leafs" written in Rust. > > In addition to some of the examples Junio mentioned elsewhere, I think > new toplevel commands, like git-replay, would qualify. > > > [1] Yeah, I really need to dig the patch out and send it in. I'll do > so shortly.