From: Derrick Stolee <derrickstolee@github.com>
Date: Thu, 12 Jan 2023 15:22:29 GMT
Subject: Re: [PATCH v2 6/6] treewide: always have a valid "index_state.repo" member
Message-ID: <f55958e0-110b-3386-b82a-154d02c71696@github.com>
In-Reply-To: <patch-v2-6.6-291233b0420-20230112T124842Z-avarab@gmail.com>

On 1/12/2023 7:55 AM, Ævar Arnfjörð Bjarmason wrote:

> We're doing this by making use of the INDEX_STATE_INIT() macro (and
> corresponding function) added in the preceding commit, which now have
> mandatory "repo" arguments. As seen here there are cases where we set
> it to NULL, but only if we're about to fill in the correct non-NULL
> "repo" right afterwards.

The changes in part 5 to depend on INDEX_STATE_INIT and
index_state_init() make the changes in this patch much more
mechanical and easy to follow.

Thanks,
-Stolee