From: René Scharfe <l.s.r@web.de>
Date: Sun, 20 Jan 2019 18:19:32 GMT
Subject: Re: [PATCH v2 2/3] blame: add the ability to ignore commits and their changes
Message-ID: <f5170cb1-4109-4ae3-7722-8e3b62fb0b92@web.de>
In-Reply-To: <20190117202919.157326-3-brho@google.com>

Am 17.01.2019 um 21:29 schrieb Barret Rhoden:
> The blame_entry will get passed up the tree until we find a commit that
> has a diff chunk that affects those lines.  If an ignored commit added
> more lines than it removed, the blame will fall on a commit that made a
> change nearby.  There is no general solution here, just a best-effort
> approach.  For a trivial example, consider ignoring this commit:
>
> Z: "Adding Lines"
>  foo
> +No commit
> +ever touched
> +these lines
>  bar

Wouldn't it make more sense to assign such lines to unknown, perhaps
represented by an all-zero commit ID, instead of blaming a semi-random
bystander?

René