From: Phillip Wood Date: Tue, 07 Feb 2023 10:52:39 GMT Subject: Re: [PATCH v3 3/4] rebase: refuse to switch to a branch already checked out elsewhere (test) Message-ID: In-Reply-To: <4580b825-b117-4581-4ea2-ab30e350b6ad@gmail.com> Hi Rubén On 06/02/2023 23:16, Rubén Justo wrote: > On 06-feb-2023 17:59:11, Ævar Arnfjörð Bjarmason wrote: > >>> Let's add a test to notice if this changes in the future. >> >> I for one would find this series much easier to follow if you started >> with this test, possibly with a test_expect_failure, and as we fix the >> relevant code flip them (both this and the subsequent one) to run >> successfully, and include them as part of the commit that fixes the >> bug). >> >> Maybe there's reasons for why that's tricky to do in this case, so >> please ignore this if so. > > I'll give it try, I like the idea. Thanks. Squashing the last three commits together so that the tests are introduced in the same commit as the fix as Junio suggested in his comments on the previous round would be very welcome. Best Wishes Phillip