From: Alexandr Miloslavskiy <alexandr.miloslavskiy@syntevo.com>
Date: Tue, 05 Nov 2019 19:37:16 GMT
Subject: Re: [PATCH 3/5] reset: support the --pathspec-from-file option
Message-ID: <f3a24b43-62ab-0912-bbd8-ae40052bc2ad@syntevo.com>
In-Reply-To: <3cee48dd-15bb-1bec-6d23-d05cce0f4eb1@gmail.com>

On 05.11.2019 17:14, Phillip Wood wrote:

>> +        OPT_FILENAME(0, "pathspec-from-file", &pathspec_from_file,
>> +                N_("read pathspecs from file")),
>> +        OPT_BOOL(0, "pathspec-file-null", &pathspec_file_null,
>> +                N_("with --pathspec-from-file, pathspecs are 
>> separated with NUL character")),
> 
> One thing I forgot to mention before is that if you're going to add 
> these options to a number of commands then maybe it is worth defining a 
> macro for each one in parse-options.h. There are a couple of examples of 
> this at the end of that file.

Thanks for the pointer!