From: Yakov Lerner <iler.ml@gmail.com>
Date: Tue, 18 Jul 2006 09:38:10 GMT
Subject: Re: comparing file contents in is_exact_match?
Message-ID: <f36b08ee0607180238i34cde4deib17426f121ae269e@mail.gmail.com>
In-Reply-To: <Pine.LNX.4.64.0607171431010.2478@evo.osdl.org>

Linus Torvalds <torvalds@osdl.org> wrote:
> Well, the thing is, you really _do_ want to mmap as much as possible of
> the pack-file as possible, if mmap() works.

Juergen Ruehle <j.ruehle@bmiag.de> wrote:
> I did some
> quick performance check and the NO_MMAP code path seems to be as fast
> as the mmap one (even much faster in some cases). So the combination
> of windows' memory management and git mmap usage doesn't seem so hot

How about making this parameter (do-use-mmap  vs  not-use-mmap)
a *runtime*  parameter  ? (Env. var. $GIT_MMAP or $GIT_USE_MMAP ?).
What do you think ? I see two benefits:
(1) much easier to benchmark two methods against each other
(2) will always work on cygwin (automatic fallback to working
    method at runtime; say depending on filesystem)

What do you say ? (Only in case when MMAP is enabled at build-time, of course)

Yakov