From: Derrick Stolee Date: Mon, 12 Nov 2018 15:32:50 GMT Subject: Re: [PATCH 4/9] sha1_file_name(): overwrite buffer instead of appending Message-ID: In-Reply-To: <20181112144856.GD7400@sigill.intra.peff.net> On 11/12/2018 9:48 AM, Jeff King wrote: > Since we're changing the semantics, let's take the opportunity to give > it a more hash-neutral name (which will also catch any callers from > topics in flight). THANK YOU! This method name confused me so much when I was first looking at the code, but the new name is so much better. -Stolee