From: Sebastian Schuberth <sschuberth@gmail.com>
Date: Thu, 27 Apr 2017 09:19:04 GMT
Subject: Re: [PATCH v2] git-gui--askpass: generalize the wording
Message-ID: <f318a3ab-930f-fa58-db3d-d28998371a86@gmail.com>
In-Reply-To: <0102015bae2176a2-8239cc7d-6510-4903-856b-e4fb0ef0cc71-000000@eu-west-1.amazonses.com>

+ Pat

On 2017-04-27 08:38, Sebastian Schuberth wrote:

> git-gui--askpass is not only used for SSH authentication, but also for
> HTTPS. In that context it is confusing to only rfer to "OpenSSH", also
> because another SSH client like PuTTY might be in use. So generalize
> wording and also say which parent process, i.e. Git, requires
> authentication.
> 
> Signed-off-by: Sebastian Schuberth <sschuberth@gmail.com>
> ---
>   git-gui/git-gui--askpass | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/git-gui/git-gui--askpass b/git-gui/git-gui--askpass
> index 4277f30..4e3f00d 100755
> --- a/git-gui/git-gui--askpass
> +++ b/git-gui/git-gui--askpass
> @@ -2,7 +2,7 @@
>   # Tcl ignores the next line -*- tcl -*- \
>   exec wish "$0" -- "$@"
>   
> -# This is a trivial implementation of an SSH_ASKPASS handler.
> +# This is a trivial implementation of an GIT_ASKPASS / SSH_ASKPASS handler.
>   # Git-gui uses this script if none are already configured.
>   
>   package require Tk
> @@ -12,7 +12,7 @@ set yesno  0
>   set rc     255
>   
>   if {$argc < 1} {
> -	set prompt "Enter your OpenSSH passphrase:"
> +	set prompt "Enter your password / passphrase:"
>   } else {
>   	set prompt [join $argv " "]
>   	if {[regexp -nocase {\(yes\/no\)\?\s*$} $prompt]} {
> @@ -60,7 +60,7 @@ proc finish {} {
>   	set ::rc 0
>   }
>   
> -wm title . "OpenSSH"
> +wm title . "Git Authentication"
>   tk::PlaceWindow .
>   vwait rc
>   exit $rc
> 


-- 
Sebastian Schuberth