From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Fri, 19 May 2017 04:42:28 GMT
Subject: Re: [PATCH 11/23] files_transaction_cleanup(): new helper function
Message-ID: <f1f8e0a1-41cc-1a48-2744-87118e39e182@alum.mit.edu>
In-Reply-To: <CAGZ79kaRZB=VTe+c-M-qnkQJGQcYb0f-V0OMRuj4o6KAUvZrrA@mail.gmail.com>

On 05/17/2017 07:26 PM, Stefan Beller wrote:
> On Wed, May 17, 2017 at 5:05 AM, Michael Haggerty <mhagger@alum.mit.edu> wrote:
>> Extract function from `files_transaction_commit()`. It will soon have
>> another caller.
> 
> This sounds odd to me. Maybe it is missing words?
> of s/function/the functionality to cleanup/

This is basically the same as the standard refactoring step "extract
method", except applied to a function, not a method. I thought these
terms would be standard enough to not need further explanation, but I'll
add some more words.

Michael