From: Thomas Rast Date: Wed, 24 Apr 2013 13:54:36 GMT Subject: [PATCH 2/3] remote: check for superfluous arguments in 'git remote add' Message-ID: In-Reply-To: The 'git remote add' subcommand did not check for superfluous command line arguments. Make it so. Signed-off-by: Thomas Rast --- builtin/remote.c | 2 +- t/t5505-remote.sh | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/builtin/remote.c b/builtin/remote.c index 937484d..5e54d36 100644 --- a/builtin/remote.c +++ b/builtin/remote.c @@ -178,7 +178,7 @@ static int add(int argc, const char **argv) argc = parse_options(argc, argv, NULL, options, builtin_remote_add_usage, 0); - if (argc < 2) + if (argc != 2) usage_with_options(builtin_remote_add_usage, options); if (mirror && master) diff --git a/t/t5505-remote.sh b/t/t5505-remote.sh index 764ee97..eea87fc 100755 --- a/t/t5505-remote.sh +++ b/t/t5505-remote.sh @@ -1020,7 +1020,7 @@ test_extra_arg () { " } -test_extra_arg -f add nick url +test_extra_arg add nick url test_extra_arg rename origin newname test_extra_arg remove origin test_extra_arg set-head origin master -- 1.8.2.1.931.g0116868