From: Derrick Stolee Date: Mon, 13 Aug 2018 11:24:34 GMT Subject: Re: [PATCH] t5318: use 'test_cmp_bin' to compare commit-graph files Message-ID: In-Reply-To: <20180812201845.2923-1-szeder.dev@gmail.com> On 8/12/2018 4:18 PM, SZEDER Gábor wrote: > The commit-graph files are binary files, so they should not be > compared with 'test_cmp', because that might cause issues on Windows, > where 'test_cmp' is a shell function to deal with random LF-CRLF > conversions. > > Use 'test_cmp_bin' instead. > > Signed-off-by: SZEDER Gábor > --- > t/t5318-commit-graph.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh > index 4f17d7701e..1c148ebf21 100755 > --- a/t/t5318-commit-graph.sh > +++ b/t/t5318-commit-graph.sh > @@ -254,9 +254,9 @@ test_expect_success 'check that gc computes commit-graph' ' > git config gc.writeCommitGraph true && > git gc && > cp $objdir/info/commit-graph commit-graph-after-gc && > - ! test_cmp commit-graph-before-gc commit-graph-after-gc && > + ! test_cmp_bin commit-graph-before-gc commit-graph-after-gc && > git commit-graph write --reachable && > - test_cmp commit-graph-after-gc $objdir/info/commit-graph > + test_cmp_bin commit-graph-after-gc $objdir/info/commit-graph > ' > > # the verify tests below expect the commit-graph to contain Thanks, Szeder! I didn't know about test_cmp_bin, and I appreciate you keeping up test hygiene. Reviewed-by: Derrick Stolee