From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 03 Oct 2006 17:50:00 GMT
Subject: Re: [PATCH] gitweb: start to generate PATH_INFO URLs.
Message-ID: <efu7r9$fra$1@sea.gmane.org>
In-Reply-To: <7vbqotpadg.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> Martin Waitz wrote:
>>
>>> +       'pathinfo' => {
>>> +               'override' => 0,
>>> +               'default' => [1]},
>>
>> You should add failsafe to gitweb_check_feature for when 'sub' is not
set;
>> for example when somebody sets $feature{'pathinfo'}{'override'} to 1.
> 
> Yes, I noticed this last night while playing with it.  We would
> at least need a big warning that says this should not be made
> overridable (which does not make any sense anyway).
> 
> Setting 'sub' to a failsafe one that only returns what is in the
> default without looking at individual repository would be the
> cleanest, I think.

Perhaps we should not add 'override' key, and test for existence
of 'override' to fallback on 'sub'.
-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git