From: Johannes Schindelin Date: Sat, 31 Jan 2015 21:05:56 GMT Subject: [PATCH v4 10/19] fsck: Make fsck_tag() warn-friendly Message-ID: In-Reply-To: When fsck_tag() identifies a problem with the commit, it should try to make it possible to continue checking the commit object, in case the user wants to demote the detected errors to mere warnings. Just like fsck_commit(), there are certain problems that could hide other issues with the same tag object. For example, if the 'type' line is not encountered in the correct position, the 'tag' line – if there is any – would not be handled at all. Signed-off-by: Johannes Schindelin --- fsck.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fsck.c b/fsck.c index b92d8c4..f72e404 100644 --- a/fsck.c +++ b/fsck.c @@ -620,7 +620,8 @@ static int fsck_tag_buffer(struct tag *tag, const char *data, } if (get_sha1_hex(buffer, sha1) || buffer[40] != '\n') { ret = report(options, &tag->object, FSCK_MSG_INVALID_OBJECT_SHA1, "invalid 'object' line format - bad sha1"); - goto done; + if (ret) + goto done; } buffer += 41; -- 2.2.0.33.gc18b867