From: Derrick Stolee Date: Wed, 29 Aug 2018 12:41:36 GMT Subject: Re: [RFC PATCH 08/12] commit-graph: convert to using the_hash_algo Message-ID: In-Reply-To: <20180829005857.980820-9-sandals@crustytoothpaste.net> On 8/28/2018 8:58 PM, brian m. carlson wrote: > Instead of using hard-coded constants for object sizes, use > the_hash_algo to look them up. In addition, use a function call to look > up the object ID version and produce the correct value. The C code in this patch looks good to me. The only issue is that I predict failure in the 'git commit-graph verify' tests in t5318-commit-graph.sh. Squashing in this commit should help (assuming that test_oid works, it doesn't at my current branch): -->8-- Subject: [PATCH] t5318-commit-graph.sh: use test_oid for HASH_LEN Signed-off-by: Derrick Stolee ---  t/t5318-commit-graph.sh | 2 +-  1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/t/t5318-commit-graph.sh b/t/t5318-commit-graph.sh index 6aee861f78..676c1a9ae0 100755 --- a/t/t5318-commit-graph.sh +++ b/t/t5318-commit-graph.sh @@ -333,7 +333,7 @@ test_expect_success 'git commit-graph verify' '  NUM_COMMITS=9  NUM_OCTOPUS_EDGES=2 -HASH_LEN=20 +HASH_LEN="$(test_oid rawsz)"  GRAPH_BYTE_VERSION=4  GRAPH_BYTE_HASH=5  GRAPH_BYTE_CHUNK_COUNT=6 -- 2.19.0.rc1