From: Jakub Narebski <jnareb@gmail.com>
Date: Sun, 17 Sep 2006 22:45:44 GMT
Subject: Re: [PATCH] gitweb: fix warnings in PATH_INFO code and add export_ok/strict_export
Message-ID: <eekj5b$rlc$1@sea.gmane.org>
In-Reply-To: <7v4pv62lni.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> Matthias Lederhofer <matled@gmx.net> writes:
> 
>> This patch replaces the other two warning fixes by Jakub and me.  I've
>> put the whole thing in a sub-routine to keep the indentation level
>> low.
> 
> Looks much cleaner with this extra sub.
> 
> This does not seem have the "colon as a cue that the URL is also
> talking about a branch", Jakub's summary of the discussion
> between you two on #git channel.  I think that proposal makes
> sense as well.

Well, that is because this patch _predates_ the discussion 
(and proposal/conclusions). 

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git