From: Jakub Narebski Date: Fri, 15 Sep 2006 07:14:23 GMT Subject: Re: [PATCH (take 2)] gitweb: Do not parse refs by hand, use git-peek-remote instead Message-ID: In-Reply-To: <7v4pv91wqk.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Jakub Narebski writes: > >> This is in response to Linus work on packed refs. Additionally it >> makes gitweb work with symrefs, too. >> >> Do not parse refs by hand, using File::Find and reading individual >> heads to get hash of reference, but use git-peek-remote output >> instead. > > Looks nicer. Will apply. > > Now, once we start doing this, it may make sense to rethink how > this function and git_get_references functions are used. [...] > I very much suspect that you can use git_get_refs_list to return > a hash and a sorted list at the same time from the same input > and make git_summary to do with just a single call to it, and > get rid of git_get_references with a little bit of restructuring > of the caller. It can be done. Well, we could also collapse git_get_references and git_get_refs_list into one subroutine, but it would be slightly slower than git_get_references. But, if we change git_get_refs_list to do also work of git_get_references, we should also change git_get_references to not use info/refs file at all (it can, and usually for unknown reasons is stale) but always use git-peek-remote, for consistency. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git