From: David Symonds Date: Fri, 09 Nov 2007 08:14:44 GMT Subject: Re: [PATCH] git-checkout: Test for relative path use. Message-ID: In-Reply-To: <7v7ikrx2st.fsf@gitster.siamese.dyndns.org> On Nov 9, 2007 7:04 PM, Junio C Hamano wrote: > "David Symonds" writes: > > > Looking at the existing tests which, when they change directories, > > don't cd back to where they were; they "cd .." at the start of the > > next test. I'll add a "cd .." to the relevant bits of my tests. > > Do not follow the bad examples, please. So what would you prefer? Bracketing the whole test in parentheses looks ugly, but I can do that if that's the only option. If I look at t5510-fetch.sh (one of yours, Junio), there is no directory restoration in the case of test failure, as in my original patch. Perhaps test_ok_ and test_failure_ in test-lib.sh should restore the directory? Dave.