From: Jakub Narebski Date: Fri, 01 Sep 2006 19:48:23 GMT Subject: Re: [PATCH] gitweb: gitweb_check_feature always return list Message-ID: In-Reply-To: <7vk64n5qep.fsf@assigned-by-dhcp.cox.net> Junio C Hamano wrote: > Jakub Narebski writes: > >> Modified feature_blame so it returns one-element list and not scalar, >> thus making gitweb_check_feature always return list. Updated comment >> to explain that part. > > I do not understand what you are fixing. > > sub A { return (1); } > sub B { return 1; } > > Don't they quack the same way? Well, that is just nitpicking. gitweb_check_feature returns list if feature is not overridable, so I made it that it always returns list. -- Jakub Narebski Warsaw, Poland ShadeHawk on #git