From: Jakub Narebski <jnareb@gmail.com>
Date: Sat, 19 Aug 2006 11:09:34 GMT
Subject: Re: [PATCH] gitweb: Support for snapshot
Message-ID: <ec6rha$aal$3@sea.gmane.org>
In-Reply-To: <7virkp3snv.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> +sub feature_snapshot {
> +       my ($ctype, $suffix, $command) = @_;
> +       my ($val) = git_get_project_config('snapshot');
> +       if ($val eq 'gzip') { return ('gzip', 'gz'); }
> +       elsif ($val eq 'bzip2') { return ('bzip2', 'bz2'); }
> +       elsif ($val eq 'none') { return (); }
> +
> +       return ($ctype, $suffix, $command);
> +}

Should it be ('x-gzip', 'gzip', 'gz') and ('x-bzip2', 'bzip2', 'bz2'),
i.e. with $ctype first?

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git