From: Kristoffer Haugsbakk Date: Thu, 28 May 2026 07:08:20 GMT Subject: Re: [PATCH 2/2] rebase: skip branch symref aliases Message-ID: In-Reply-To: <0ab0a717441e9fc7c494da194065a948a35a7f01.1779946921.git.gitgitgadget@gmail.com> On Thu, May 28, 2026, at 07:42, Son Luong Ngoc via GitGitGadget wrote: >[snip] > -test_expect_failure '--update-refs skips branch symrefs to current branch' ' > +test_expect_success '--update-refs skips branch symrefs to current branch' ' > test_when_finished " > test_might_fail git rebase --abort && > git checkout primary && This style of fixing a bug by: • Add failing test `test_expect_failure` in the first commit • Fix the bug in the next commit and flip to `test_expect_success` Is legitimate and makes it easier to verify that the test really exercises the regression. But in this project it is preferred to just do the bug fix + regression test in one patch. See https://lore.kernel.org/git/xmqqfrdk3aqy.fsf@gitster.g/ > -- > gitgitgadget