From: Jakub Narebski <jnareb@gmail.com>
Date: Thu, 17 Aug 2006 09:49:03 GMT
Subject: Re: gitweb: Support for snapshots in gitweb
Message-ID: <ec1e0j$bqr$1@sea.gmane.org>
In-Reply-To: <44E40CB1.7040805@gmail.com>

Aneesh Kumar K.V wrote:

> +       print $cgi->header(-type=>'application/x-tar', -Content-Encoding=>'x-gzip',
> +               '-content-disposition' => "inline; filename=\"$project.tar.gz\"",
> +               -status=> '200 OK');

Wouldn't it be better to put $hash somewhere in the name?

And please remember that $project can contain slashes, so it should be processed
(only basename of $project, perhaps).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git