From: Derrick Stolee <stolee@gmail.com>
Date: Fri, 22 Nov 2024 11:46:04 GMT
Subject: Re: [PATCH 1/7] pack-objects: add --full-name-hash option
Message-ID: <ec17fdd8-310e-42b6-bdf6-2620a84c2eb3@gmail.com>
In-Reply-To: <Zz+nk4w+y63vCupK@nand.local>

On 11/21/24 4:35 PM, Taylor Blau wrote:
> On Thu, Nov 21, 2024 at 03:08:09PM -0500, Taylor Blau wrote:
>> The remaining parts of this change look good to me.
> 
> Oops, one thing I forgot (which reading Peff's message in [1] reminded
> me of) is that I think we need to disable full-name hashing when we're
> reusing existing packfiles as is the case with try_partial_reuse().
> 
> There we're always looking at classic name hash values, so mixing the
> two would be a mistake. I think that amounts to:
> 
> --- 8< ---
> diff --git a/builtin/pack-objects.c b/builtin/pack-objects.c
> index 762949e4c8..7e370bcfc9 100644
> --- a/builtin/pack-objects.c
> +++ b/builtin/pack-objects.c
> @@ -4070,6 +4070,8 @@ static int get_object_list_from_bitmap(struct rev_info *revs)
>   	if (!(bitmap_git = prepare_bitmap_walk(revs, 0)))
>   		return -1;
> 
> +	use_full_name_hash = 0;
> +
Thanks. I have applied this code change with a comment detailing
the context around the bitmap file storing only the default name-hash
(for now) but that it can change in the future.

Thanks,
-Stolee