From: Jakub Narebski <jnareb@gmail.com>
Date: Tue, 15 Aug 2006 16:45:35 GMT
Subject: Re: [PATCH 9/9] gitweb: Separate printing difftree in git_commit into git_difftree_body
Message-ID: <ebstls$3gt$3@sea.gmane.org>
In-Reply-To: <7vfyfybzlf.fsf@assigned-by-dhcp.cox.net>

Junio C Hamano wrote:

> Jakub Narebski <jnareb@gmail.com> writes:
> 
>> +            if ($status eq "A") { # created
>>...
>> +            } elsif ($status eq "D") { # deleted
>>...
>> +            } elsif ($status eq "M" || $status eq "T") { # modified, or type changed
>>...
>> +            } elsif ($status eq "R") { # renamed
>>...
>> +            } elsif ($status eq "C") { # copied
>>...
>> +            } # we should not encounter Unmerged (U) or Unknown (X) status
> 
> The body of these still seem to have quite a lot of
> similarities.  Maybe further refactoring is in the works?

Probably. For now I only separated the difftree printing part into separate 
subroutine, and added $status eq "C" case (I don't know if we might encounter
it at all, due to current set of options to diff-tree).

-- 
Jakub Narebski
Warsaw, Poland
ShadeHawk on #git