From: Jeff Hostetler Date: Wed, 23 Mar 2022 20:14:53 GMT Subject: Re: What's cooking in git.git (Mar 2022, #04; Thu, 17) Message-ID: In-Reply-To: On 3/23/22 2:28 PM, Junio C Hamano wrote: > Jeff Hostetler writes: > >> On 3/17/22 7:34 AM, Junio C Hamano wrote: >>> * jh/builtin-fsmonitor-part-2plus (2022-03-13) 16 commits >>> - fsmonitor-settings: simplify initialization of settings data >>> - fsmonitor--daemon: add _() to calls to error() >>> - fsmonitor--daemon: add _() to calls to die() >>> - compat/fsmonitor/fsm-listen-win32: add _() to calls to error() >>> - compat/fsmonitor/fsm-listen-darwin: add _() to calls to error() >>> - fsmonitor-ipc: add _() to calls to die() >>> - t7527: delete unused verify_status() function >>> - t7527: fix && chaining in matrix_try() >>> - t7527: add parameters to start_daemon to handle args and subshell >>> - t/perf/p7519: cleanup coding style >>> - t/perf/p7519: use grep rather than egrep in test >>> - fsmonitor--daemon: refactor cookie handling for readability >>> - t/helper/fsmonitor-client: cleanup call to parse_options() >>> - compat/fsmonitor/fsm-listen-darwin: split out GCC-specific declarations >>> - update-index: convert advise() messages back to warning() >>> - t/test-lib: avoid using git on LHS of pipe >>> (this branch uses jh/builtin-fsmonitor-part2.) >>> Various small fixes and cleanups on part-2 of the same topic. >>> Needs review. >>> source: >> >> I have squashed this into part 2 V7, so this series can be >> discarded. Thanks (and sorry for the mess). > > Will take a (hopefully final) look, and ... > > >>> * jh/builtin-fsmonitor-part3 (2022-03-09) 28 commits >>> ... >>> . Merge branch 'jh/builtin-fsmonitor-part2' into jh/builtin-fsmonitor-part3 >>> (this branch uses jh/builtin-fsmonitor-part2.) >>> More fsmonitor--daemon. >>> source: >> >> I just sent a V3 of part 3 that builds upon V7 of part 2. >> The fixups from part 2.5 have been squashed in. > > ... queue the updated one on top. > > Thanks. > I have a V8 of Part 2 that addresses AEvar's last round of comments from yesterday (mostly related to the test suite). It's building now on GGG. If there are no other comments by the morning, I'll send it (and an updated Part 3 to match) tomorrow and hopefully Part 2 can be done. Thanks Jeff