From: Phillip Wood Date: Thu, 08 Feb 2024 14:26:11 GMT Subject: Re: [PATCH 2/2] sequencer: unset GIT_CHERRY_PICK_HELP for 'exec' commands Message-ID: In-Reply-To: Hi Vegard On 08/02/2024 08:48, Vegard Nossum wrote: > I'm sorry, but I'm confused about what I'm supposed to do now. > > There is now another test case and it sounds like you would prefer that > one over mine, but I didn't write it and there is no SOB, so I cannot > submit that with the fix if I were to "squash them together". Here's my SOB for the diff in https://lore.kernel.org/git/4e6d503a-8564-4536-82a7-29c489f5fec3@gmail.com/ Signed-off-by: Phillip Wood I think that typically for small suggestions like that we just add a Helped-by: trailer but feel free to add my SOB if you want. > I am not a regular contributor so I don't have a good grasp on things > like why you don't want a new test file for this, I think keeping related tests together helps contributors see which test files to run when they're changing code (running the whole suite each time is too slow). There is also a (small) setup overhead for each new file. For tests like this it is a bit ambiguous whether it belongs with the other "rebase --exec" tests or the other "cherry-pick" tests. I opted to put it with the other "rebase --exec" tests as I think it is really fixing a bug with rebase rather than cherry-pick. Best Wishes Phillip