From: phillip.wood123@gmail.com
Date: Tue, 02 Jul 2024 15:14:09 GMT
Subject: Re: [PATCH 3/6] t-ctype: use TEST_RUN
Message-ID: <eae0ccf4-8747-400c-96ab-b7fc7a51beb9@gmail.com>
In-Reply-To: <1a9c7351-68c2-4f2a-b00f-b4c8422ebe08@web.de>

Hi René

On 01/07/2024 21:04, René Scharfe wrote:
> Am 01.07.24 um 21:49 schrieb Josh Steadmon:
>> On 2024.06.29 17:44, René Scharfe wrote:
>>> Use the macro TEST_RUN instead of the internal functions
>>> test__run_begin() and test__run_end().
>>>
>>> Signed-off-by: René Scharfe <l.s.r@web.de>
>>
>> Nitpick: please expand the commit message here as you did for the
>> following patches.
> 
> There is not much more to it: Use of internal functions is discouraged,
> so this patch replaces their calls with the new public feature.  Perhaps
> a "Kinda-requested-by: Phillip Wood <phillip.wood@dunelm.org.uk>" would
> be appropriate?

Perhaps something like

These tests use the internal functions test__run_begin() and 
test__run_end() which are supposed to be private to the test framework. 
Convert them to use the newly added TEST_RUN() instead.

would be sufficient?

Best Wishes

Phillip

> Unlike in the later patches the tests themselves are unchanged, so this
> has no consequence for people that want to add or modify character
> classifier tests.
> 
> René