From: Derrick Stolee <derrickstolee@github.com>
Date: Mon, 19 Sep 2022 16:12:20 GMT
Subject: Re: [PATCH 3/8] osxkeychain: clarify that we ignore unknown lines
Message-ID: <ead6293c-8906-04c9-6566-e47efb624385@github.com>
In-Reply-To: <2ece562a5952b5752de5040b17ec36076164c72f.1663097156.git.gitgitgadget@gmail.com>

On 9/13/2022 3:25 PM, Matthew John Cheetham via GitGitGadget wrote:
> From: Matthew John Cheetham <mjcheetham@outlook.com>
> 
> Like in all the other credential helpers, the osxkeychain helper
> ignores unknown credential lines.
> 
> Add a comment (a la the other helpers) to make it clear and explicit
> that this is the desired behaviour.

I recommend that these first three patches be submitted for full
review and merging, since they seem important independent of this
RFC.

Thanks,
-Stolee