From: Johannes Schindelin Date: Mon, 08 Jun 2015 14:27:09 GMT Subject: Re: [PATCH 2/2] fsck: report errors if reflog entries point at invalid objects Message-ID: In-Reply-To: <2ba9ee48a062b049c8b64fed4caba32c42f03031.1433769878.git.mhagger@alum.mit.edu> Hi Michael, On 2015-06-08 08:40, Michael Haggerty wrote: > Previously, if a reflog entry's old or new SHA-1 was not resolvable to > an object, that SHA-1 was silently ignored. Instead, report such cases > as errors. I like the idea, but I am a bit uncertain whether it would constitute "too backwards-incompatible" a change to make this an error. I think it could be argued both ways: it *is* an improvement, but it could also possibly disrupt scripts that work pretty nicely at the moment. My fsck-api branch will help with this, of course, as users whose scripts break could be (temporarily) demote the error to a warning. I planned to work on it this week and would be happy to rebase it onto this here patch series. Ciao, Dscho