From: Derrick Stolee <stolee@gmail.com>
Date: Fri, 27 Dec 2019 14:52:10 GMT
Subject: Re: [PATCH 2/3] commit-graph: free large diffs, too
Message-ID: <e932bed5-f90c-da51-7d45-54e14aa27734@gmail.com>
In-Reply-To: <20191222093216.GB3460818@coredump.intra.peff.net>

On 12/22/2019 4:32 AM, Jeff King wrote:
> If a diff we compute for --changed-path has more than 512 entries, we
> don't bother generating a bloom filter for it. But since we don't
> iterate over diff_queued_diff, we also don't free the filepairs and
> filespecs from the diff before clearing the queue. Let's make sure we do
> so.
> 
> This drops the peak heap usage of "commit-graph write --changed-paths"
> on linux.git from ~8GB to ~4GB.

In my testing, the heap size went from ~10gb to ~6gb.

Thanks,
-Stolee