From: Michael Haggerty <mhagger@alum.mit.edu>
Date: Wed, 17 May 2017 14:01:57 GMT
Subject: Re: [PATCH 01/23] t3600: clean up permissions test properly
Message-ID: <e8ac4b86-12a7-57c0-421b-a3ba90709464@alum.mit.edu>
In-Reply-To: <20170517124255.62hdqwvcvfy2tdr7@sigill.intra.peff.net>

On 05/17/2017 02:42 PM, Jeff King wrote:
> On Wed, May 17, 2017 at 02:05:24PM +0200, Michael Haggerty wrote:
> 
>> The test of failing `git rm -f` removes the write permissions on the
>> test directory, but fails to restore them if the test fails. This
>> means that the test temporary directory cannot be cleaned up, which
>> means that subsequent attempts to run the test fail mysteriously.
>>
>> Instead, do the cleanup in a `test_must_fail` block so that it can't
>> be skipped.
> 
> This should be `test_when_finished` in the final paragraph, right?

Yes, thanks. Will fix.

Michael